This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"

From: Daniel Jacobowitz <drow at false dot org>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, gdb-patches at sourceware dot org
Date: Sun, 15 Nov 2009 12:25:10 -0500
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <m23a4g5fur.fsf@whitebox.home> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com>

On Sun, Nov 15, 2009 at 09:16:06AM -0800, Paul Pluzhnikov wrote:
> The only way I can see to allow general expressions here is to require
> a separator which can't happen in any expression in any language
> (semicolon probably comes close), or for parse_expression() to consume
> as much as it can and set a "end_of_parse" indicator.
> 
> But perhaps splitting on comma (after skipping any quoted expression
> -- Foo::bar could have multiple parameters) is "good enough"? That
> would allow 'disas &main + 1, &main + 5' to work.

See parse_to_comma_and_eval (which I always forget about in this
situation...).

It's not perfect, but it does handle parenthesis nesting.

-- 
Daniel Jacobowitz
CodeSourcery

References:
- [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Andreas Schwab
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]