This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 06/15] PIE: Fix displacement of separate debug info files
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 Nov 2009 12:04:19 -0700
- Subject: Re: [patch 06/15] PIE: Fix displacement of separate debug info files
- References: <20091109205855.GG19138@host0.dyn.jankratochvil.net>
- Reply-to: tromey at redhat dot com
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Fix displacement of separate debug info files.
Jan> * objfiles.c (objfile_relocate): Rename to ...
Jan> (objfile_relocate1): ... here and make it static. Extend the comment.
Jan> (objfile_relocate): New function.
Jan> * solib-spu.c (spu_relocate_main_executable): Explicitly check if
Jan> SYMFILE_OBJFILE is NULL. Remove variables objfile and old_chain.
Jan> Remove following of SEPARATE_DEBUG_OBJFILE. new_offsets is now
Jan> allocated using alloca.
Jan> * symfile.c (build_section_addr_info_from_objfile): New function.
Jan> (symbol_file_add_with_addrs_or_offsets): Remove variable orig_addrs and
Jan> its initialization.
Jan> (symbol_file_add_with_addrs_or_offsets <debugfile>): Call
Jan> build_section_addr_info_from_objfile instead.
Jan> * symfile.h (build_section_addr_info_from_objfile): New prototype.
Jan> - if (addrs)
Jan> - {
Jan> - orig_addrs = copy_section_addr_info (addrs);
I think this was the last call to copy_section_addr_info, so this patch
should remove that function as well (unless you use it in a different
patch in the series? I didn't check).
Ok with this change.
Tom