This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gcore registers storing fix




Daniel Jacobowitz wrote:
On Mon, Nov 09, 2009 at 05:32:12PM -0300, Daniel Gutson wrote:

Daniel Jacobowitz wrote:
On Mon, Nov 09, 2009 at 03:36:02PM -0300, Daniel Gutson wrote:
Because none of them checks that the text "in ??" does *not* show up
Michael has pointed out that this text can legitimately appear.
If there is a function in the system libraries without debug
information, we may be there.  For instance, inside the implementation
of printf.
OK, should I just remove the test case then? That, or only check that
the ?? is not in the current thread.

Let's drop the new test. The code part of your patch is OK to commit.

OK, thanks. Please note that I don't have write access, please commit it for me if ever possible.


--
Daniel Gutson
CodeSourcery
www.codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]