This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Don't split executable paths with spaces in into multiple arguments
>>>>> "Joel" == Joel Brobecker <firstname.lastname@example.org> writes:
>> It seems to me that it would not be significantly harder for the code to
>> do the correct thing in all cases.
Joel> To be honest, I didn't even think about it, mostly because I thought
Joel> that the issue would be so rare that it was possibly just retorical.
Joel> So I felt that I shouldn't insist that we do the right thing in all
Joel> cases. Too lax?
Ordinarily my view is "forward biased": an improvement is an
improvement, and requiring perfection tends to raise the patch
submission bar too high.
In this particular case, though, I would probably have pushed back a
bit, first because the patch is already fixing a previous "can't happen"
assumption, and second because the correct code is really just 4 or 5
lines. (I thought for sure we would already have the quoting code lying
around, but I grepped a little and couldn't find it. It is odd that we
have buildargv to split the argv but nothing to quote it.)