This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h

Hui Zhu wrote: 
OK.  I make a new patch for it.
Please help me review it.


It looks ok to me, but I have only linux systems on which to
evaluate it.  I'd like a 2nd opinion.  Pedro?

2009-10-26  Michael Snyder  <msnyder@vmware.com>
            Hui Zhu  <teawater@gmail.com>

        * Makefile.in (SFILES): Add gcore.c.
        (COMMON_OBS): Add gcore.o.
        * config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
        * config/alpha/fbsd.mh (NATDEPFILES): Ditto.
        * config/arm/linux.mh (NATDEPFILES): Ditto.
        * config/i386/fbsd.mh (NATDEPFILES): Ditto.
        * config/i386/fbsd64.mh (NATDEPFILES): Ditto.
        * config/i386/i386sol2.mh (NATDEPFILES): Ditto.
        * config/i386/linux.mh (NATDEPFILES): Ditto.
        * config/i386/linux64.mh (NATDEPFILES): Ditto.
        * config/i386/sol2-64.mh (NATDEPFILES): Ditto.
        * config/ia64/linux.mh (NATDEPFILES): Ditto.
        * config/m32r/linux.mh (NATDEPFILES): Ditto.
        * config/m68k/linux.mh (NATDEPFILES): Ditto.
        * config/mips/linux.mh (NATDEPFILES): Ditto.
        * config/pa/linux.mh (NATDEPFILES): Ditto.
        * config/powerpc/linux.mh (NATDEPFILES): Ditto.
        * config/powerpc/ppc64-linux.mh (NATDEPFILES): Ditto.
        * config/s390/s390.mh (NATDEPFILES): Ditto.
        * config/sparc/fbsd.mh (NATDEPFILES): Ditto.
        * config/sparc/linux.mh (NATDEPFILES): Ditto.
        * config/sparc/linux64.mh (NATDEPFILES): Ditto.
        * config/sparc/sol2.mh (NATDEPFILES): Ditto.
        * config/xtensa/linux.mh (NATDEPFILES): Ditto.
        * target.c (dummy_find_memory_regions): Change output.
        (dummy_make_corefile_notes): Ditto.

---
 Makefile.in                   |    4 ++--
 config/alpha/alpha-linux.mh   |    2 +-
 config/alpha/fbsd.mh          |    2 +-
 config/arm/linux.mh           |    2 +-
 config/i386/fbsd.mh           |    2 +-
 config/i386/fbsd64.mh         |    2 +-
 config/i386/i386sol2.mh       |    2 +-
 config/i386/linux.mh          |    2 +-
 config/i386/linux64.mh        |    2 +-
 config/i386/sol2-64.mh        |    2 +-
 config/ia64/linux.mh          |    2 +-
 config/m32r/linux.mh          |    2 +-
 config/m68k/linux.mh          |    2 +-
 config/mips/linux.mh          |    2 +-
 config/pa/linux.mh            |    2 +-
 config/powerpc/linux.mh       |    2 +-
 config/powerpc/ppc64-linux.mh |    2 +-
 config/s390/s390.mh           |    2 +-
 config/sparc/fbsd.mh          |    2 +-
 config/sparc/linux.mh         |    2 +-
 config/sparc/linux64.mh       |    2 +-
 config/sparc/sol2.mh          |    2 +-
 config/xtensa/linux.mh        |    2 +-
 target.c                      |   14 ++++++++------
 24 files changed, 32 insertions(+), 30 deletions(-)

--- a/Makefile.in
+++ b/Makefile.in
@@ -681,7 +681,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
        wrapper.c \
        xml-tdesc.c xml-support.c \
        inferior.c gdb_usleep.c \
-       record.c \
+       record.c gcore.c\
        jit.c \
        xml-syscall.c \

@@ -834,7 +834,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
        solib.o solib-null.o \
        prologue-value.o memory-map.o xml-support.o xml-syscall.o \
        target-descriptions.o target-memory.o xml-tdesc.o xml-builtin.o \
-       inferior.o osdata.o gdb_usleep.o record.o \
+       inferior.o osdata.o gdb_usleep.o record.o gcore.o \
        jit.o progspace.o

 # Definitions for the syscall's XML files and dir
--- a/config/alpha/alpha-linux.mh
+++ b/config/alpha/alpha-linux.mh
@@ -1,7 +1,7 @@
 # Host: Little-endian Alpha running Linux
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o corelow.o alpha-linux-nat.o \
-       fork-child.o proc-service.o linux-thread-db.o gcore.o \
+       fork-child.o proc-service.o linux-thread-db.o \
        linux-nat.o linux-fork.o

 # The dynamically loaded libthread_db needs access to symbols in the
--- a/config/alpha/fbsd.mh
+++ b/config/alpha/fbsd.mh
@@ -1,6 +1,6 @@
 # Host: FreeBSD/alpha
 NATDEPFILES= fork-child.o inf-ptrace.o \
        fbsd-nat.o alphabsd-nat.o bsd-kvm.o \
-       gcore.o corelow.o core-regset.o
+       corelow.o core-regset.o

 LOADLIBES= -lkvm
--- a/config/arm/linux.mh
+++ b/config/arm/linux.mh
@@ -1,7 +1,7 @@
 # Host: ARM based machine running GNU/Linux

 NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o arm-linux-nat.o \
        proc-service.o linux-thread-db.o linux-nat.o linux-fork.o

 LOADLIBES= -ldl -rdynamic
--- a/config/i386/fbsd.mh
+++ b/config/i386/fbsd.mh
@@ -1,7 +1,7 @@
 # Host: FreeBSD/i386
 NATDEPFILES= fork-child.o inf-ptrace.o \
        fbsd-nat.o i386-nat.o i386bsd-nat.o i386fbsd-nat.o \
-       gcore.o bsd-kvm.o
+       bsd-kvm.o
 NAT_FILE= nm-fbsd.h

 LOADLIBES= -lkvm
--- a/config/i386/fbsd64.mh
+++ b/config/i386/fbsd64.mh
@@ -1,6 +1,6 @@
 # Host: FreeBSD/amd64
 NATDEPFILES= fork-child.o inf-ptrace.o \
        fbsd-nat.o amd64-nat.o amd64bsd-nat.o amd64fbsd-nat.o \
-       gcore.o bsd-kvm.o
+       bsd-kvm.o

 LOADLIBES= -lkvm
--- a/config/i386/i386sol2.mh
+++ b/config/i386/i386sol2.mh
@@ -1,4 +1,4 @@
 # Host: Solaris x86
 NATDEPFILES= fork-child.o i386v4-nat.o i386-sol2-nat.o \
-       procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+       procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
 NAT_FILE= nm-i386sol2.h
--- a/config/i386/linux.mh
+++ b/config/i386/linux.mh
@@ -3,7 +3,7 @@
 NAT_FILE= nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o \
        i386-nat.o i386-linux-nat.o \
-       proc-service.o linux-thread-db.o gcore.o \
+       proc-service.o linux-thread-db.o \
        linux-nat.o linux-fork.o

 # The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/linux64.mh
+++ b/config/i386/linux64.mh
@@ -1,7 +1,7 @@
 # Host: GNU/Linux x86-64
 NATDEPFILES= inf-ptrace.o fork-child.o \
        i386-nat.o amd64-nat.o amd64-linux-nat.o linux-nat.o \
-       proc-service.o linux-thread-db.o gcore.o  linux-fork.o
+       proc-service.o linux-thread-db.o linux-fork.o
 NAT_FILE= config/nm-linux.h

 # The dynamically loaded libthread_db needs access to symbols in the
--- a/config/i386/sol2-64.mh
+++ b/config/i386/sol2-64.mh
@@ -1,4 +1,4 @@
 # Host: Solaris x86_64
 NATDEPFILES= fork-child.o amd64-nat.o i386v4-nat.o i386-sol2-nat.o \
-       procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o gcore.o
+       procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
 NAT_FILE= nm-i386sol2.h
--- a/config/ia64/linux.mh
+++ b/config/ia64/linux.mh
@@ -1,7 +1,7 @@
 # Host: Intel IA-64 running GNU/Linux

 NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
        core-regset.o ia64-linux-nat.o \
        proc-service.o linux-thread-db.o linux-nat.o linux-fork.o

--- a/config/m32r/linux.mh
+++ b/config/m32r/linux.mh
@@ -2,7 +2,7 @@

 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o corelow.o       \
-       m32r-linux-nat.o gcore.o proc-service.o linux-thread-db.o       \
+       m32r-linux-nat.o proc-service.o linux-thread-db.o       \
        linux-nat.o linux-fork.o

 LOADLIBES= -ldl -rdynamic
--- a/config/m68k/linux.mh
+++ b/config/m68k/linux.mh
@@ -2,7 +2,7 @@

 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o \
-       corelow.o m68klinux-nat.o gcore.o \
+       corelow.o m68klinux-nat.o \
        proc-service.o linux-thread-db.o linux-nat.o linux-fork.o

 # The dynamically loaded libthread_db needs access to symbols in the
--- a/config/mips/linux.mh
+++ b/config/mips/linux.mh
@@ -1,7 +1,7 @@
 # Host: Linux/MIPS
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o mips-linux-nat.o \
-       linux-thread-db.o proc-service.o gcore.o \
+       linux-thread-db.o proc-service.o \
        linux-nat.o linux-fork.o

 LOADLIBES = -ldl -rdynamic
--- a/config/pa/linux.mh
+++ b/config/pa/linux.mh
@@ -1,6 +1,6 @@
 # Host: Hewlett-Packard PA-RISC machine, running Linux
 NAT_FILE= config/nm-linux.h
-NATDEPFILES= inf-ptrace.o fork-child.o corelow.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o corelow.o \
        hppa-linux-nat.o proc-service.o linux-thread-db.o linux-nat.o \
        linux-fork.o

--- a/config/powerpc/linux.mh
+++ b/config/powerpc/linux.mh
@@ -5,6 +5,6 @@ XM_CLIBS=
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o \
        ppc-linux-nat.o proc-service.o linux-thread-db.o \
-       gcore.o linux-nat.o linux-fork.o
+       linux-nat.o linux-fork.o

 LOADLIBES = -ldl -rdynamic
--- a/config/powerpc/ppc64-linux.mh
+++ b/config/powerpc/ppc64-linux.mh
@@ -5,7 +5,7 @@ XM_CLIBS=
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o \
        ppc-linux-nat.o proc-service.o linux-thread-db.o \
-       gcore.o linux-nat.o linux-fork.o
+       linux-nat.o linux-fork.o

 # The PowerPC has severe limitations on TOC size, and uses them even
 # for non-PIC code.  GDB overflows those tables when compiling with
--- a/config/s390/s390.mh
+++ b/config/s390/s390.mh
@@ -1,5 +1,5 @@
 # Host: S390, running Linux
 NAT_FILE= config/nm-linux.h
 NATDEPFILES= inf-ptrace.o fork-child.o corelow.o s390-nat.o \
-       gcore.o linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
+       linux-thread-db.o proc-service.o linux-nat.o linux-fork.o
 LOADLIBES = -ldl -rdynamic
--- a/config/sparc/fbsd.mh
+++ b/config/sparc/fbsd.mh
@@ -1,6 +1,6 @@
 # Host: FreeBSD/sparc64
 NATDEPFILES= fork-child.o inf-ptrace.o \
        fbsd-nat.o sparc-nat.o sparc64-nat.o sparc64fbsd-nat.o \
-       gcore.o bsd-kvm.o
+       bsd-kvm.o

 LOADLIBES= -lkvm
--- a/config/sparc/linux.mh
+++ b/config/sparc/linux.mh
@@ -3,7 +3,7 @@ NAT_FILE= config/nm-linux.h
 NATDEPFILES= sparc-nat.o sparc-linux-nat.o \
        corelow.o core-regset.o fork-child.o inf-ptrace.o \
        proc-service.o linux-thread-db.o \
-       gcore.o linux-nat.o linux-fork.o
+       linux-nat.o linux-fork.o

 # The dynamically loaded libthread_db needs access to symbols in the
 # gdb executable.
--- a/config/sparc/linux64.mh
+++ b/config/sparc/linux64.mh
@@ -4,7 +4,7 @@ NATDEPFILES= sparc-nat.o sparc64-nat.o s
        corelow.o core-regset.o \
        fork-child.o inf-ptrace.o \
        proc-service.o linux-thread-db.o \
-       gcore.o linux-nat.o linux-fork.o
+       linux-nat.o linux-fork.o

 # The dynamically loaded libthread_db needs access to symbols in the
 # gdb executable.
--- a/config/sparc/sol2.mh
+++ b/config/sparc/sol2.mh
@@ -1,5 +1,5 @@
 # Host: Solaris SPARC & UltraSPARC
 NAT_FILE= nm-sol2.h
 NATDEPFILES= sparc-sol2-nat.o \
-       corelow.o core-regset.o fork-child.o gcore.o \
+       corelow.o core-regset.o fork-child.o \
        procfs.o proc-api.o proc-events.o proc-flags.o proc-why.o
--- a/config/xtensa/linux.mh
+++ b/config/xtensa/linux.mh
@@ -2,7 +2,7 @@

NAT_FILE= config/nm-linux.h

-NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o gcore.o \
+NATDEPFILES= inf-ptrace.o fork-child.o xtensa-linux-nat.o \
        linux-thread-db.o proc-service.o linux-nat.o linux-fork.o

 LOADLIBES = -ldl -rdynamic
--- a/target.c
+++ b/target.c
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
   return normal_pid_to_str (ptid);
 }

-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions.  */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
   return 0;
 }

-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes.  */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
   return NULL;
 }

On Mon, Oct 26, 2009 at 11:34, Michael Snyder <msnyder@vmware.com> wrote:
Hui Zhu wrote:
Hi Michael,

I make a patch that move gcore.o to makefile.in.
It will make record save build OK in cygwin.

Not quite good for targets that don't use "exec" (such as
remote or sim).  We'll expose an error message that isn't
very informative.

Could you add this diff to your patch?


Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.229
diff -u -p -r1.229 target.c
--- target.c    20 Oct 2009 11:09:01 -0000      1.229
+++ target.c    26 Oct 2009 03:39:36 -0000
@@ -2751,17 +2751,19 @@ dummy_pid_to_str (struct target_ops *ops
  return normal_pid_to_str (ptid);
 }

-/* Error-catcher for target_find_memory_regions */
-static int dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
+/* Error-catcher for target_find_memory_regions.  */
+static int
+dummy_find_memory_regions (int (*ignore1) (), void *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
  return 0;
 }

-/* Error-catcher for target_make_corefile_notes */
-static char * dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
+/* Error-catcher for target_make_corefile_notes.  */
+static char *
+dummy_make_corefile_notes (bfd *ignore1, int *ignore2)
 {
-  error (_("No target."));
+  error (_("Command not implemented for this target."));
  return NULL;
 }




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]