This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [commit] multi-executable support

On Tuesday 20 October 2009 07:13:58, Hui Zhu wrote:
> darwin-nat.c
>   if (breakpoint_inserted_here_p (pc))

Thanks.  "grep breakpoint_inserted_here_p *nat*" doesn't find
any other missing adjustment in native target files.  I've no easy way
to test this, but the needed change is very simple.  Plus, this
function is a copy of linux-nat.c:cancel_breakpoint, where I did
the exact same change.

I'm applying this.

2009-10-20  Pedro Alves  <>

	* darwin-nat.c (cancel_breakpoint): Pass the regcache's address
	space to breakpoint_inserted_here_p.

 gdb/darwin-nat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: src/gdb/darwin-nat.c
--- src.orig/gdb/darwin-nat.c	2009-10-20 12:15:12.000000000 +0100
+++ src/gdb/darwin-nat.c	2009-10-20 12:16:03.000000000 +0100
@@ -995,7 +995,7 @@ cancel_breakpoint (ptid_t ptid)
   CORE_ADDR pc;
   pc = regcache_read_pc (regcache) - gdbarch_decr_pc_after_break (gdbarch);
-  if (breakpoint_inserted_here_p (pc))
+  if (breakpoint_inserted_here_p (get_regcache_aspace (regcache), pc))
       inferior_debug (4, "cancel_breakpoint for thread %x\n",
 		      ptid_get_tid (ptid));

Pedro Alves

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]