This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix for internal-error: linux_nat_post_attach_wait: Assertion `pid == new_pid && WIFSTOPPED (status)' failed.


On Wednesday 14 October 2009 22:28:26, Paul Pluzhnikov wrote:
> I am having a bit of trouble coming up with the right verbiage.
> How about:
> 
>   error (_("Unable to attach: program exited normally."));
> 
> Alternatives:
> 
>   error (_("While attaching program exited normally."));
>   error (_("During attach program exited normally."));
> 
> don't sound grammatically correct to me (and a comma is probably
> missing from at least one of the above).

I've no preference really.  Any of those is fine with me.
If someone else wants to suggest something, I'm sure they'll
speak up now.  :-)

Something else I noticed:

> +         int signo = WTERMSIG (status);

Should be:

        enum target_signal signo = target_signal_from_host (WTERMSIG (status));

> +
> +         target_terminal_ours ();
> +         target_mourn_inferior ();
> +         error (_("During startup program terminated with signal %s, %s."),
> +                target_signal_to_name (signo),
> +                target_signal_to_string (signo));

                   ^^^^^^^^^^^^^^^^^^^^^^^

because these functions take a target independent gdb
signal (TARGET_SIGNAL_...).  Yes, it's confusing.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]