This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jiang Jilin <freephp at gmail dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, Michael Snyder <msnyder at vmware dot com>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 9 Oct 2009 19:33:44 -0700
- Subject: Re: [PATCH] Add xgetbv/xsetbv instructions support for precord.
- References: <firstname.lastname@example.org> <20091009172119.GA5272@adacore.com> <email@example.com>
> Sorry, but I don't know how to verify it, please help me with it. When
> I ran 'make check', it displayed some 'FAIL' messages even before my
> patch, and I noticed runtest uses
> /usr/share/dejagnu/baseboards/unix.exp, which is not given by
> http://sourceware.org/gdb/wiki/ReversibleDebugging. How to use
> runtest to test precord.exp only?
I will let Michael and Hui explain to you how to use the special
board file precord.exp.
The FAILs are expected, as is simply impossible to mark all failures
for all platforms. There are too many variables, such as your compiler,
your kernel, etc etc etc. So what you need to do is run the testsuite
before and after your patch, saving the contents of gdb.sum after the
first run, and then do a comparison of the two files, to make sure
that your patch did not cause any unexpected change. Some tests are
a little unpredictable, and cause you to see some apparent regressions
that may not be caused by your patch. You'll have to use your judgement
in these cases.
> No, I don't have an FSF assignment on file, but I'd like to. How to
> have an FSF assignment on file?
I'll send you the form to fill in and send to the FSF immediately.