This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Set calling convention of methods

> From: Jonas Maebe <>
> Date: Thu, 1 Oct 2009 11:17:54 +0200
> > Overall, this looks OK to me, but Mark seemed interested in reviewing
> > this patch, so please wait for his comments as well.
> Ok. Note that my mail client is known to wrap text at 80 columns (and  
> adds a space at the end of each wrapped line for detecting this  
> operation). This behaviour cannot be disabled afaik, and yes, one  
> could certainly consider this to be a bug. At the same time, it  
> however also adds '"Format="flowed"; DelSp="yes"' to the Content-Type  
> header, so mail clients on the other side can reconstruct the original  
> text (if those clients support these modifiers, which I hope is the  
> case).

It's sad that modern graphical e-mail clients get in the way here and
generate all this complicated crap.

Some people using similarly broken mail clients circumvent the problem
by including a diff both inline and as an attachment.  While not
ideal, that's an acceptable solution to me.

> 2009-10-01  Jonas Maebe  <jonas.maebe <at>>
> 	Add support for the "Borland fastcall" calling convention.
> 	* dwarf2.h: Add DW_CC_GNU_borland_fastcall_i386 constant.
> 	* i386-tdep.c: #include dwarf2.h
> 	(i386_borland_fastcall_push_dummy_call): New.
> 	(i386_push_dummy_generic_call): Renamed i386_push_dummy_call.
> 	(i386_push_dummy_call): New dispatch function that calls
> 	i386_generic_push_dummy_call or i386_push_dummy_borland_fast_call
> 	depending on the calling convention.
> 	* gdb.dwarf2/dw2-borland_fastcall.exp: New.
> 	* gdb.dwarf2/dw2-borland_fastcall.S: New.

The i386-tdep.c bits are fine with me.  I haven't been following the
dwarf2.h discussion too closely; whatever consensus that's reached
there is fine with me.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]