This is the mail archive of the
mailing list for the GDB project.
Re: [patch] Set calling convention of methods
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jonas Maebe <jonas dot maebe at elis dot ugent dot be>
- Cc: Tom Tromey <tromey at redhat dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Thu, 1 Oct 2009 15:04:30 -0700
- Subject: Re: [patch] Set calling convention of methods
- References: <691B0BA8-C606-42FF-A796-76CC9C31556A@elis.ugent.be> <200904222215.n3MMF0p2006994@brahms.sibelius.xs4all.nl> <19C107AA-5271-4C23-A6D2-AFF75BBAC4E4@elis.ugent.be> <email@example.com> <5AA3BCA9-1ECF-446E-8B49-3132F0E470FB@elis.ugent.be> <20090930000225.GA10338@adacore.com> <8F3B6095-4766-432D-ABB5-AB4DAA2D5572@elis.ugent.be> <267A47C4-C452-4EC5-B74E-7C5C26AF227E@elis.ugent.be> <20090930162510.GE10338@adacore.com> <C3FC6AD4-40BC-4CC2-8E6F-AFAA072EDC70@elis.ugent.be>
> Ok. Note that my mail client is known to wrap text at 80 columns
If that's the case, then let's avoid inlined patches. We sometimes try
to apply your patch for various reasons such as testing, etc. I'd rather
have an encoded attachment rather than a malformed patch.
> Given that it was later confirmed that the file does belong to gcc,
> should I resend my patch for dwarf2.h to the gcc patches list?
Yes please. Ping them until someone finally gives the OK. Do mention
that this needs to be accepted under the "tiny change" rule, as you
are still working on copyright assignment for GCC.
I'll review the rest of the patch hopefully tomorrow.