This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB 6.8.92 available for testing
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- Cc: ralf dot corsepius at rtems dot org, gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com, tromey at redhat dot com
- Date: Thu, 1 Oct 2009 12:40:34 -0700
- Subject: Re: GDB 6.8.92 available for testing
- References: <20090930204828.GB31446@adacore.com> <4AC41F44.1040502@rtems.org> <20091001170744.GC6532@adacore.com> <4AC4E4F6.5080500@rtems.org> <200910011733.n91HXDnX007084@brahms.sibelius.xs4all.nl> <20091001182740.GG6532@adacore.com> <200910011836.n91IacEh027960@brahms.sibelius.xs4all.nl>
[switching to gcc-patches]
> Given that newer GCC versions get whinier and whinier and that we see
> false positives from time to time, I would be in favour of disabling
> -Werror for releases.
Makes sense to me. I've just committed the following patch on the branch,
after having re-built GDB on x86-linux, making sure that -Werror is no
longer used by default anymore. (this is the same patch than the one
I applied for GDB 6.6 by the way).
2009-10-01 Joel Brobecker <brobecker@adacore.com>
* configure.ac: Disable -Werror by default.
* configure: Regenerate.
I'll update my release procedure/scripts to do the same for future
releases.
--
Joel
Index: configure.ac
===================================================================
RCS file: /cvs/src/src/gdb/configure.ac,v
retrieving revision 1.106
diff -u -p -r1.106 configure.ac
--- configure.ac 10 Sep 2009 03:59:36 -0000 1.106
+++ configure.ac 1 Oct 2009 19:17:55 -0000
@@ -1510,11 +1510,6 @@ AC_ARG_ENABLE(werror,
*) AC_MSG_ERROR(bad value ${enableval} for --enable-werror) ;;
esac])
-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
- ERROR_ON_WARNING=yes
-fi
-
WERROR_CFLAGS=""
if test "${ERROR_ON_WARNING}" = yes ; then
WERROR_CFLAGS="-Werror"
Index: configure
===================================================================
RCS file: /cvs/src/src/gdb/configure,v
retrieving revision 1.288
diff -u -p -r1.288 configure
--- configure 10 Sep 2009 03:59:37 -0000 1.288
+++ configure 1 Oct 2009 19:17:59 -0000
@@ -13067,11 +13067,6 @@ if test "${enable_werror+set}" = set; th
fi
-# Enable -Werror by default when using gcc
-if test "${GCC}" = yes -a -z "${ERROR_ON_WARNING}" ; then
- ERROR_ON_WARNING=yes
-fi
-
WERROR_CFLAGS=""
if test "${ERROR_ON_WARNING}" = yes ; then
WERROR_CFLAGS="-Werror"