This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Speed up find_pc_section
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: ppluzhnikov at google dot com (Paul Pluzhnikov)
- Cc: brobecker at adacore dot com (Joel Brobecker), Ulrich dot Weigand at de dot ibm dot com (Ulrich Weigand), gdb-patches at sourceware dot org (gdb-patches ml), tromey at redhat dot com (Tom Tromey)
- Date: Mon, 14 Sep 2009 18:41:30 +0200 (CEST)
- Subject: Re: [patch] Speed up find_pc_section
Paul Pluzhnikov wrote:
> On Tue, Sep 8, 2009 at 10:38 PM, Joel Brobecker<brobecker@adacore.com> wrote:
>
> > Otherwise, the patch seems fine. I would love some input from Ulrich,
> > though.
>
> Thanks for the review. Attached patch implements your suggestions.
> --
> Paul Pluzhnikov
>
>
> 2009-09-10 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> *minsyms.c (lookup_minimal_symbol_by_pc_section_1): Assert non-NULL
> section.
> (lookup_minimal_symbol_by_pc_section): Check for NULL section.
> (lookup_minimal_symbol_by_pc): Adjust.
This looks good to me as well, thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com