This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PING][RFC-v3] Add windows Thread Information Block


  I got the approval for the windows part from Christopher 
a long while ago, but nothing for the rest of the patch :(

  Pedro, could you please tell me
if I should add a different TARGET_OBJECT type
or if the patch is acceptable as is?
  I don't think that the fact that TARGET_OBJECT_OSDATA
is using XML for other osdata is a real stopper,
but you need to decide and let me know, please.


Pierre Muller
Pascal language support maintainer for GDB




> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Pierre Muller
> Envoyé?: Friday, July 03, 2009 6:12 PM
> À?: gdb-patches@sourceware.org; drow@false.org
> Cc?: 'Pedro Alves'
> Objet?: [RFC-v3] Add windows Thread Information Block
> 
> 
>   Here is a new version of this patch:
> 
>   - It does add a convenience variable name "$_tlb"
> for "thread local base" as this is the only value that needs
> to be fetch especially.
>    Maybe "_tib" is better, in the sense that it "talks" more to
> windows used debuggers? But this is really only a pointer and not the
> block itself. Any better idea?
> 
>   I tried to create a type that really fits
> the Windows OS layout, but as this structure is not documented really
> and has changed between OS version, there can be no
> assurance that all fields are OK in all versions...
>   It works both native and remotely.
> 
>  I didn't check if it works OK, if endianess are different
> but the extra field in extract_unsigned_integer should take care
> of this.
> 
>   As Christopher reported problems trying to apply my previous
> version, I attach it this time, hoping that this will avoid troubles.
> 
>   Pedro, I didn't change the TARGET_OBJECT type,
> and I really want to know if this is really required,
> as it seems to be a lot of work and I can't see the benefit...
> 
> 
> Pierre Muller
> Pascal language support maintainer for GDB
> 
> 
> 
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]