This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: Lazy bitfields
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: gdb-patches at sourceware dot org, Vladimir Prus <vladimir at codesourcery dot com>, Daniel Jacobowitz <dan at codesourcery dot com>
- Date: Fri, 28 Aug 2009 07:28:35 -0700
- Subject: Re: RFC: Lazy bitfields
- References: <20090717192526.GB6863@caradoc.them.org> <20090721181826.GE11667@caradoc.them.org>
On Tue, Jul 21, 2009 at 11:18 AM, Daniel Jacobowitz<drow@false.org> wrote:
> On Fri, Jul 17, 2009 at 03:25:26PM -0400, Daniel Jacobowitz wrote:
>> 2009-07-17 ?Daniel Jacobowitz ?<dan@codesourcery.com>
>> ? ? ? ? ? Vladimir Prus <vladimir@codesourcery.com>
>>
>> ? ? ? * valops.c (value_fetch_lazy): Handle bitfields explicitly.
>> ? ? ? (value_assign): Remove unnecessary FIXME. ?Honor the container
>> ? ? ? type of bitfields if possible.
>> ? ? ? * value.c (struct value): Add parent field.
>> ? ? ? (value_parent): New function.
>> ? ? ? (value_free): Free the parent also.
>> ? ? ? (value_copy): Copy the parent also.
>> ? ? ? (value_primitive_field): Do not read the contents of a lazy
>> ? ? ? value to create a child bitfield value. ?Set bitpos and offset
>> ? ? ? according to the container type if possible.
>> ? ? ? (unpack_bits_as_long): Rename from unpack_field_as_long. ?Take
>> ? ? ? field_type, bitpos, and bitsize instead of type and fieldno.
>> ? ? ? (unpack_field_as_long): Use unpack_bits_as_long.
>> ? ? ? * value.h (value_parent, unpack_bits_as_long): New prototypes.
>
> Checked in.
>
This breaks bitfield:
http://sourceware.org/bugzilla/show_bug.cgi?id=10565
--
H.J.