Re: [patch] Speed up find_pc_section

[Paul Pluzhnikov <ppluzhnikov at google dot com>]

On Fri, Aug 21, 2009 at 4:30 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:

> (A cleaner fix might be to fix all callers to never pass in a NULL
> section argument --most already don't-- and simply rely on it.)

Attached patch does that ...
Not tested (I still haven't figured out how to test overlays).

> I'm still not completely happy about the assertions you added. ?An
> assertion failure is supposed to be an indication of a bug in GDB
> -- it should never be possible to trigger the assertion just by
> providing particular user input (this includes the binary file).

I am still working on fixing that part...

Thanks,
--
Paul Pluzhnikov

2009-08-23  Paul Pluzhnikov  <ppluzhnikov@google.com>

        * minsyms.c (lookup_minimal_symbol_by_pc_section_1): Assume
non-NULL section.
        (lookup_minimal_symbol_by_pc_section): Check for NULL section.
        (lookup_minimal_symbol_by_pc): Adjust.

Attachment: gdb-overlay-fix-20090823.txt
Description: Text document