This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[ob] Fix tests in make check

I noticed while diffing test logs that sometimes the tests
were not being run.  The reason is code in the top level makefile that
passes GCJ=$(GCJ) in the export list to sub-makes.  It never
supplies a default $GCJ, but it does set the environment variable - to
the empty string.

Rather than muck about with configury, I've checked in this simple
patch to ignore $env(GCJ) if it is empty.  Now these two commands
give me the same results (2 FAILs, incidentally):

make -C gdb/testsuite check RUNTESTFLAGS=jprint.exp
make check-gdb RUNTESTFLAGS=jprint.exp

Daniel Jacobowitz

2009-07-06  Daniel Jacobowitz  <>

	* lib/java.exp (java_init): Ignore $GCJ if it is empty.

Index: lib/java.exp
RCS file: /cvs/src/src/gdb/testsuite/lib/java.exp,v
retrieving revision 1.11
diff -u -p -r1.11 java.exp
--- lib/java.exp	3 Jan 2009 05:58:08 -0000	1.11
+++ lib/java.exp	6 Jul 2009 19:13:15 -0000
@@ -45,7 +45,7 @@ proc java_init { args } {
 	if [info exists TOOL_EXECUTABLE] {
 	} else {
-	    if [info exists env(GCJ)] {
+	    if { [info exists env(GCJ)] && $env(GCJ) != "" } {
 		set GCJ_UNDER_TEST $env(GCJ)
 	    } else {
 		global tool_root_dir

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]