This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [13/15] Address printing


  Hi all,

  it seems to me that
  paddress has a noticeably different behavior from
  removed paddr function:
  
  paddr was always of the size of 2*ptr_size
and had no leading '0x' while paddress
doesn't have a fixed length and has a leading '0x'.

  I was wondering if there are no testsuite failures
related to that change.


  core_addr_to_string seems also not to display 
addresses with the size of the current target:
it uses sizeof (CORE_ADDR) which might be different
from the size of the current target especially for
--enable-targets=all.

  I saw that you used phex (addr, addr_size)
at several places, wouldn't be better to
use target_gdbarch pointer size if target_gdbarch 
is valid and fall back to sizeof (CORE_ADDR) only
if current target is not set or if the pointer size 
is not set?


Pierre Muller
Pascal language support maintainer for GDB




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]