This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Accelerate blocks sorting


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> GDB has been reported as hanging on crashed webkit.
Jan> https://bugzilla.redhat.com/show_bug.cgi?id=507267

This is also http://sourceware.org/bugzilla/show_bug.cgi?id=9988

Jan> +  return (BLOCK_START (b) > BLOCK_START (a))
Jan> +	 - (BLOCK_START (b) < BLOCK_START (a));

This expression needs parens around it, according to GNU rules.

Jan> +      barray = xmalloc (sizeof (*barray) * count);
Jan> +      back_to = make_cleanup (xfree, barray);

I think you don't actually need a cleanup here, as nothing here can
call error.  However, if you want to leave it, that is also ok with
me.

This is ok with a fix to the formatting nit.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]