This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Eliminate quadratic slow-down on number of solibs (part 2).
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Tue, 12 May 2009 10:25:30 +0200
- Subject: Re: [patch] Eliminate quadratic slow-down on number of solibs (part 2).
- References: <8ac60eac0905051749p3b5d14d9q8903b9de8e18137f@mail.gmail.com>
> Even after the two patches above, there is still some repeated
> and unnecessary setting and resetting of the breakpoints as each
> solib is added :-(
>
> Attached is an alternative patch which subsumes the other two,
> and kills additional 15% of wasted CPU time.
>
> It feels like a hack, but I don't see how to achieve the same
> result in a cleaner way :-(
I haven't had a chance to look at the other patch, but, yeah,
it does feel like a hack! :-/.
But I'm sympathetic to the issue - it's tough to have to wait
an extra 20secs when you know that you don't have any breakpoint
refering to any SO... My thoughts on this: Perhaps a setting
in the "maintenance set/show" that the user could change to deactivate
breakpoint reset. The default is the current behavior, but if the user
knows what he's doing, he can change it. Not sure what the other
maintainers think about that. Horrible, but better than nothing.
That being said, I still think we should try to do as good a job
as we can automatically, so your first suggestion should also be
incorporated.
--
Joel