Re: [PATCH] Improve the fetch/store of general-purpose and floating-point PowerPC registers

[Joel Brobecker <brobecker at adacore dot com>]

> > Sorry for the delay in reviewing this. I don't know much about ptrace
> > except as a user, but this seems to make sense. The only request I have
> > is for you to write a small comment describing each new function you
> > introduce. The patch is OK with those changes.
> 
> So the request is about the ChangeLog, right?  Ok, I'll resubmit it with
> the modifications as soon as possible.

Actually, no. The comments are for the functions themselves. We're
trying to make sure that every new function gets in with some
documentation of what it does. It doesn't have to be very long,
but sometimes writing what the return value is about is very useful.
For instance, I remember that some of your functions will return
zero if the operation failed, I think.  That's an interesting piece
of information to put in the documentation.  When the function is
obvious, or when it implements a routine that's part of the gdbarch
vector, then what we've been doing, lately, is just say "Implements
the "bla_bla_bla" gdbarch method." or somesuch (we try not to repeat
the documentation to avoid maintenance issues).

-- 
Joel