This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] Fix compilation warning in procfs.c on mips-irix
On Thu, Apr 16, 2009 at 11:45:39AM -0700, Joel Brobecker wrote:
> > - return (*func) ((CORE_ADDR) map->pr_vaddr,
> > + return (*func) ((CORE_ADDR) (uintptr_t) map->pr_vaddr,
> > map->pr_size,
> > (map->pr_mflags & MA_READ) != 0,
> > (map->pr_mflags & MA_WRITE) != 0,
> >
> > Isn't this a problem for MIPS, due to pointer sign-extension?
>
> Hmmm, you are probably right. I reverted the patch for now, and will look
> further into your suggestion a bit later.
Note, if you don't have any code above 0x80000000, it doesn't much
matter... I don't remember how the MIPS bits ever came to be used, or
if they were theoretical. Threaded code on 32-bit MIPS Linux is
always going to be below KSEG0 at 0x80000000.
--
Daniel Jacobowitz
CodeSourcery