This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA/Obvious] AR Index abort function use rule fix


Current ARI shows a regression on 
use of abort function.
 This is related to the fact that there
are four usages of abort () in utils.c
but gdb_ari.sh only lists 3.
$ grep -w abort utils.c
utils.c:        abort ();       /* NOTE: GDB has only four calls to abort().
*/
utils.c:          abort (); /* NOTE: GDB has only four calls to abort().  */
utils.c:        abort ();               /* NOTE: GDB has only four calls to
abort().  */
utils.c:            abort ();           /* NOTE: GDB has only four calls to
abort().  */

  I would have committed this myself under obvious rule,
but the problem is that I have no write permission to
this folder anymore...

Commit entry log:
	* gdb_ari.sh (abort rule): Change number of expected
	abort occurrences in utils.c to 4.

  Daniel, is this OK?
If yes, could you check it in for me?


Pierre Muller
Pascal language support maintainer for GDB



$ cvs diff -up gdb_ari.sh
Index: gdb_ari.sh
===================================================================
RCS file: /cvs/gdbadmin/ss/gdb_ari.sh,v
retrieving revision 1.78
diff -u -p -r1.78 gdb_ari.sh
--- gdb_ari.sh  18 Mar 2009 02:57:33 -0000      1.78
+++ gdb_ari.sh  23 Mar 2009 12:41:59 -0000
@@ -563,7 +563,7 @@ Replace obj_private with objfile_data"
 BEGIN { doc["abort"] = "\
 Do not use abort, instead use internal_error; GDB should never abort"
     category["abort"] = ari_regression
-    fix("abort", "gdb/utils.c", 3)
+    fix("abort", "gdb/utils.c", 4)
 }
 /(^|[^_[:alnum:]])abort[[:space:]]*\(/ {
     fail("abort")



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]