This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix a crash when displaying variables from shared library.


Hi guys,

On Thursday 05 March 2009 23:46:32, Paul Pluzhnikov wrote:
> > I suggest a different approach:
> >
> > ?| # Start the program, we should land in the program main procedure
> > ?| if { [gdb_start_cmd] < 0 } {
> > ?| ? ? fail "Can't run to main"
> > ?| ? ? return -1
> > ?| }
> > ?|
> > ?| gdb_test "" \
> > ?| ? ? ? ? ?"first \\(\\) at .*first.adb.*" \
> > ?| ? ? ? ? ?"start first"
> >
> > The second gdb_test should allow you to verify that the debugger
> > displays your variables correctly.
> 
> Looks good.
> 
> Attached is the patch I just committed.

I just noticed that this test is failing against gdbserver:

  FAIL: gdb.base/solib-display.exp: Can't run to main (2)

The problem is that gdb_start_cmd is a nop for remote targets:

proc gdb_start_cmd {args} {
...
    if [target_info exists use_gdb_stub] {
        return -1
    }

What do you think?  Should we skip this test for remote
targets, or perhaps we do things differently here?

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]