This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] testsuite: Fix a racy FAIL on gdb.base/multi-forks.exp
> gdb/testsuite/
> 2009-03-13 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix a racy FAIL.
> * gdb.base/multi-forks.exp (continue_to_exit_bp_loc): New function with
> code from `follow parent, print pids'.
> (`follow child, print pids', `follow parent, print pids'): Call it.
> Replace `gdb_test "break..."' by gdb_breakpoint.
This seems pretty reasonable to me...
> +# Continue till where $exit_bp_loc points at eating all the inferior output
> +# which could otherwise corrupt our later communication with GDB.
I am so sorry to be picking on your comments. I very much appreciate
the fact that you spend the time writing them, especially since most
people tend to not write comments. In this case, this comments also
sounds strange. Here is a suggestion:
# Insert a breakpoint at the location provided by the exit_bp_loc global
# and resume the execution until hitting that breakpoint. We also make
# sure to consume all the expected output from all processes as well,
# to make sure it doesn't cause trouble during a subsequent test.
--
Joel