This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] disassemble-next-line


Hi Pedro.

The enum auto_boolean and add_setshow_auto_boolean_cmd is cool.
Thanks for you remind me.

I had changed it.  Do you think it's OK?

Thanks,
Hui

On Fri, Mar 13, 2009 at 08:20, Pedro Alves <pedro@codesourcery.com> wrote:
>> --- a/stack.c
>> +++ b/stack.c
>>
>> +/* Enum strings for "set|show disassemble-next-line". ?*/
>> +
>> +static const char disassemble_next_line_auto[] = "auto";
>> +static const char disassemble_next_line_on[] = "on";
>> +static const char disassemble_next_line_off[] = "off";
>> +static const char *disassemble_next_line_enum[] =
>> +{
>> + ?disassemble_next_line_auto,
>> + ?disassemble_next_line_on,
>> + ?disassemble_next_line_off,
>> + ?NULL,
>> +};
>
> Please make this an `enum auto_boolean' / AUTO_BOOLEAN_AUTO, and
> register the "disassemble-next-line" command with
> add_setshow_auto_boolean_cmd instead.
>
> --
> Pedro Alves
>

Attachment: disassemble-next-line.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]