This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: gdb.objc/objcdecode.exp test error..
Matt,
(interesting email address :-)
As far as I can tell, the copyright assignment papers you filed with
the FSF only covers GNUSTEP. We can take this change in as a "tiny
change", but it would be better if you had a proper copyright assignment
at least for GDB (I suggest to assign any past and future changes
to any GNU software and be done with it, but I understand if you prefer
to choose a more limited list of projects). Once you are covered for
GDB, let us know and we can add you to the list of contributors that
have write-after-approval access to the GDB repository.
> i should probably come up with another test for multiple-symbols all,
> so neither failure gets forgotten, but i'll have to learn more about
> dejagnu before i'm able to do that.
That would be very nice if you could add these extra tests.
It makes sense to test the behaviour in the "ask" case, but we really
ought to try to test the default case as well.
It shouldn't be very hard: Try it by hand, and then add a gdb_test
with the expected output. The expected output regular expression
can be a bit hairy because you have to escape backslashes, but
otherwise, it's fairly simple to program by copy/paste.
> +2009-03-05 Matt Rice <ratmice@gmail.com>
> +
> + * gdb.objc/objcdecode.exp: Set the multiple symbols found behaviour
> + to ask.
In the meantime, this looks reasonable to me. I can check it in
for you if you'd like.
--
Joel