This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: pedro at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 18 Feb 2009 11:12:03 +0100 (CET)
- Subject: Re: Fix most -Wmissing-prototypes -Wmissing-declarations warnings
- References: <200902180201.05118.pedro@codesourcery.com>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Wed, 18 Feb 2009 02:01:04 +0000
>
> 3) several cases of _initialize_foo not being declared.
>
> +/* -Wmissing-prototypes */
> +extern initialize_file_ftype _initialize_cli_logging;
> +
I absolutely detest using initialize_file_ftype for this, since my
brain fails to parse this as a function prototype.
And, the GNU coding standards still demand full sentences, so in the
past I've written stuff like:
/* Provide a prototype to silence -Wmissing-prototypes. */
void _initialize_i386_tdep (void);
I don't feel too strongly about the last point, but it'd be nice to
see consistency here.