This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PING: Get rid of linux-thread-db.c:target_beneath
- From: Pedro Alves <pedro at codesourcery dot com>
- To: teawater <teawater at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 10 Feb 2009 16:41:31 +0000
- Subject: Re: PING: Get rid of linux-thread-db.c:target_beneath
- References: <daef60380902100839r61d2997em1f572efee30a04fe@mail.gmail.com>
On Tuesday 10 February 2009 16:39:13, teawater wrote:
> Hi Pedro,
>
> Sorry to disturb you. Could you please help me review these patches?
Yes, I will. It's on my queue.
>
> Thanks,
> Hui
>
> On Sun, Feb 8, 2009 at 21:15, teawater <teawater@gmail.com> wrote:
> >
>
> > >
> > > If you do that, you get rid of the record_beneath_to_resume,
> > > record_beneath_to_wait, record_beneath_to_store_registers, etc.
> > > function pointer hacks you had. The wrinkle that has, is that your
> > > method ends up responsible for doing the default if no target
> > > implements the method. IMO, that would acceptible for
> > > now. But, it can be fixed.
> > >
> >
> > I see.
> >
> > So I make a new patch for it. Could you please help me review it?
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00187.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00188.html
> >
> > And I make some new patches to fix the format errors. Please help me review it.
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00189.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00190.html
> > http://sourceware.org/ml/gdb-patches/2009-02/msg00192.html
> >
> > Thanks,
> > Hui
>
--
Pedro Alves