This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: small get_prev_frame cleanup (don't allow a NULL this_frame anymore), plus caller adjustment
- From: Daniel Jacobowitz <drow at false dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 1 Feb 2009 13:37:22 -0500
- Subject: Re: small get_prev_frame cleanup (don't allow a NULL this_frame anymore), plus caller adjustment
- References: <200901260026.59013.pedro@codesourcery.com>
On Mon, Jan 26, 2009 at 12:26:58AM +0000, Pedro Alves wrote:
> To clean that up, the best seems to be to export ``has_stack_frames'',
> which is also the predicate used by deprecated_get_selected_frame and
> get_selected_frame, and use it at the get_prev_frame's and
> deprecated_get_seleted_frame caller (varobj_create). (This is not to
> say that checks couldn't move yet closer to the top-level, but I'm
> leaving that for another time --- focusing on get_prev_frame.)
>
> WDYT?
I think this is OK. Another choice would be to push
find_frame_addr_in_frame_chain into frame.c... but we do not want
anything else to use it.
--
Daniel Jacobowitz
CodeSourcery