This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep...


> >This patch moves the win32_xfer_shared_library function to a file
> >that is not specific to the target CPU.  I introduced win32-tdep,
> >to follow the naming scheme used by win32-nat, even though these
> >file can also work on 64bit windows.
> 
> If this file can work on 64 bit windows then it seems like it should be
> renamed to something more generic rather than potentially duplicating
> the same code in two places.
> 
> Should win32-nat.c just be renamed to windows-nat.c?

I think this would be a good idea. Same for win32-tdep.

I suggest I commit the two remaining patches as is, and then do
the move as a separate step.  That way, I don't have to rework
the patches after the move is done.

In terms of the move itself, how do we want it to be done.
CVS doesn't support moves per se. Usually, in my own little CVS
repos where I don't use branches, I do a "mv" inside the CVS
repository.  But I know that this brings its own problems.
Should we use "cvs remove + cvs add"?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]