This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

get rid of new gdb_suppress_entire_file calls


Just noticed that these tests reintroduced calls to gdb_suppress_entire_file.

This replaces them with the usual `untested ...; return -1' pair.

-- 
Pedro Alves
2008-12-31  Pedro Alves  <pedro@codesourcery.com>

	* gdb.threads/attach-into-signal.exp: Don't use
	gdb_suppress_entire_file.
	* gdb.threads/attach-stopped.exp: Ditto.
	* gdb.threads/attachstop-mt.exp: Ditto.

---
 gdb/testsuite/gdb.threads/attach-into-signal.exp |    6 ++++--
 gdb/testsuite/gdb.threads/attach-stopped.exp     |    6 ++++--
 gdb/testsuite/gdb.threads/attachstop-mt.exp      |    3 ++-
 3 files changed, 10 insertions(+), 5 deletions(-)

Index: src/gdb/testsuite/gdb.threads/attach-into-signal.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.threads/attach-into-signal.exp	2008-12-31 01:57:28.000000000 +0000
+++ src/gdb/testsuite/gdb.threads/attach-into-signal.exp	2008-12-31 01:58:50.000000000 +0000
@@ -144,7 +144,8 @@ gdb_exit
 # build the test case first without threads
 #
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    gdb_suppress_entire_file "Testcase nonthraded compile failed, so all tests in this file will automatically fail."
+    untested "attach-into-signal.exp (unthreaded)"
+    return -1
 }
 
 gdb_start
@@ -157,7 +158,8 @@ corefunc nonthreaded
 # build the test case also with threads
 #
 if  { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DUSE_THREADS}] != "" } {
-    gdb_suppress_entire_file "Testcase threaded compile failed, so all tests in this file will automatically fail."
+    untested "attach-into-signal.exp (threaded)"
+    return -1
 }
 
 gdb_start
Index: src/gdb/testsuite/gdb.threads/attach-stopped.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.threads/attach-stopped.exp	2008-12-31 02:00:21.000000000 +0000
+++ src/gdb/testsuite/gdb.threads/attach-stopped.exp	2008-12-31 02:01:08.000000000 +0000
@@ -141,7 +141,8 @@ proc corefunc { threadtype } {
 # build the test case first without threads
 #
 if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    gdb_suppress_entire_file "Testcase nonthraded compile failed, so all tests in this file will automatically fail."
+    untested "attach-stopped.exp (unthreaded)"
+    return -1
 }
 
 corefunc nonthreaded
@@ -149,7 +150,8 @@ corefunc nonthreaded
 # build the test case first without threads
 #
 if  { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug additional_flags=-DUSE_THREADS}] != "" } {
-    gdb_suppress_entire_file "Testcase threaded compile failed, so all tests in this file will automatically fail."
+    untested "attach-stopped.exp (threaded)"
+    return -1
 }
 
 corefunc threaded
Index: src/gdb/testsuite/gdb.threads/attachstop-mt.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.threads/attachstop-mt.exp	2008-12-31 01:59:43.000000000 +0000
+++ src/gdb/testsuite/gdb.threads/attachstop-mt.exp	2008-12-31 02:18:31.000000000 +0000
@@ -36,7 +36,8 @@ remote_exec build "rm -f ${binfile}"
 # build the test case
 #
 if  { [gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
-    gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail."
+    untested attachstop-mt.exp
+    return -1
 }
 
 if [get_compiler_info ${binfile}] {

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]