This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
PR8812 - Stray ``Signal Stop Print ...'' in handle command
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Date: Wed, 31 Dec 2008 01:39:23 +0000
- Subject: PR8812 - Stray ``Signal Stop Print ...'' in handle command
I've check in this fix to plug PR8812.
From the PR:
handle SIGINT nopass
SIGINT is used by the debugger.
Are you sure you want to change it? (y or n) n
Not confirmed, unchanged.
Signal Stop Print Pass to program Description
(gdb)
Notice the stray ``Signal Stop ...'' line
No regressions on x86_64-linux, and I've also confirmed that the
stray header is the only change visible in the dejagnu log when
running the signals.exp test.
--
Pedro Alves
2008-12-31 Pedro Alves <pedro@codesourcery.com>
PR gdb/8812:
* infrun.c (handle_command): Don't print a header or notify the
target about signal changes if we didn't change any signal.
2008-12-31 Pedro Alves <pedro@codesourcery.com>
PR gdb/8812:
* gdb.base/signal.exp: Change kfail to fail, and update PR number.
---
gdb/infrun.c | 28 +++++++++++++++-------------
gdb/testsuite/gdb.base/signals.exp | 2 +-
2 files changed, 16 insertions(+), 14 deletions(-)
Index: src/gdb/infrun.c
===================================================================
--- src.orig/gdb/infrun.c 2008-12-31 01:26:39.000000000 +0000
+++ src/gdb/infrun.c 2008-12-31 01:27:41.000000000 +0000
@@ -4639,20 +4639,22 @@ Are you sure you want to change it? ", t
argv++;
}
- target_notice_signals (inferior_ptid);
+ for (signum = 0; signum < nsigs; signum++)
+ if (sigs[signum])
+ {
+ target_notice_signals (inferior_ptid);
+
+ if (from_tty)
+ {
+ /* Show the results. */
+ sig_print_header ();
+ for (; signum < nsigs; signum++)
+ if (sigs[signum])
+ sig_print_info (signum);
+ }
- if (from_tty)
- {
- /* Show the results. */
- sig_print_header ();
- for (signum = 0; signum < nsigs; signum++)
- {
- if (sigs[signum])
- {
- sig_print_info (signum);
- }
- }
- }
+ break;
+ }
do_cleanups (old_chain);
}
Index: src/gdb/testsuite/gdb.base/signals.exp
===================================================================
--- src.orig/gdb/testsuite/gdb.base/signals.exp 2008-12-31 01:26:39.000000000 +0000
+++ src/gdb/testsuite/gdb.base/signals.exp 2008-12-31 01:27:41.000000000 +0000
@@ -248,7 +248,7 @@ The program being debugged stopped while
gdb_test_multiple "n" "$test" {
-re "Not confirmed, unchanged.*Signal.*$gdb_prompt $" {
# "Signal ..." should not be in the output.
- kfail gdb/1707 "$test"
+ fail gdb/8812 "$test"
}
-re "Not confirmed, unchanged.*$gdb_prompt $" {
pass "$test"