Re: [RFA/Ada] remove ref to fields and ref to slices

[Jerome Guitton <guitton at adacore dot com>]

Joel Brobecker (brobecker@adacore.com):

> >  static struct value *
> >  ada_value_slice_ptr (struct value *array_ptr, struct type *type,
> >                       int low, int high)
> 
> Could you rename this function to "ada_value_slice"? Since we no longer
> return a pointer to the slice but the slice itself, the _ptr suffix
> could be confusing.

Not really. ada_value_slice already exists: same function, but it works
on array. ada_value_slice_ptr, at the contrary, works on pointers to
array or references. Maybe ada_value_slice_from_ptr would be clearer?



> 
> > @@ -6178,9 +6178,7 @@ ada_index_struct_field_1 (int *index_p, 
> >  /* Given ARG, a value of type (pointer or reference to a)*
> >     structure/union, extract the component named NAME from the ultimate
> >     target structure/union and return it as a value with its
> > -   appropriate type.  If ARG is a pointer or reference and the field
> > -   is not packed, returns a reference to the field, otherwise the
> > -   value of the field (an lvalue if ARG is an lvalue).     
> > +   appropriate type.  Return the value of the field.
> 
> The last sentence you added seems redundant with the one before it
> (that you adjusted).

Right. Thank you for catching it.