This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: How to submit a LARGE patch


> From: Jeremy Bennett <jeremy.bennett@embecosm.com>
> Date: Sat, 20 Sep 2008 12:22:25 +0100
> 
> How do I submit a LARGE patch to this group.

My own preference is to submit is as text, not as binary attachment.
Unless your mailer does all kinds of dirty tricks with text, such as
folding long lines etc., this makes reviewing the patch by far the
easiest.

> I've made some suggested changes to the GDB Internals manual, but since
> the change includes an image, the diff file is nearly 300k, when gzipped
> and uuencoded.

How large it is before gzip?

> Second question. When I create the diff file from the patch, is that
> expected to be relative to the main source tree, or just the directory
> containing the changes (in this case the gdb/doc directory).

It doesn't matter, at least not to me.  The information about the
directory is included in the diffs, so applying them correctly is
easy.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]