This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix 'incomplete type' warning in dummy_frame.h


David Daney wrote:

> Back on 2008-08-26, Ulrich Weigand added a declaration for
> dummy_frame_pop to dummy_frame.h.  This causes a fatal warning when I
> build with gcc-3.4 targeting mipsel-linux-gnu because struct frame_id is
> an incomplete type.
> 
> Adding #include "frame.h" fixes the problem for me.

Huh.  Sorry for the breakage.  Strange that this compiles without even
a warning with GCC 4.1.1 ...

> I'm don'e think I have write access to gdb (I do have it in binutils),
> so if it is OK, someone will either have to commit it or turn on write
> access for me.

If you have access to binutils, you should also have access in GDB, 
as both actually reside in the same src repository.

> 2008-09-07  David Daney  <ddaney@avtrex.com>
> 
> 	* dummy-frame.h (frame.h): Include it.
> 	(struct frame_id): Remove declaration.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]