This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch to send telnet BREAK for remote-over-tcp


On Wed, Sep 03, 2008 at 10:12:22AM -0700, Michael Snyder wrote:
> Daniel Jacobowitz wrote:
>> On Tue, Sep 02, 2008 at 09:35:29PM -0700, Michael Snyder wrote:
>>> I think this looks right, but I'd love to get another opinion.
>>>
>>> Daniel?  Anybody?
>>
>> It seems fine (aside from the parenthesis formatting :-P), though I
>> think it would be much more useful if added to the manual.
>
> OK, since I don't know if Angela has write privs, I'll fix
> the parens and check it in later today.
>
> Should this change be propagated to ser-mingw.c?  It shares
> some code with this module but makes up its own serial_ops
> struct.
>
> If not, I'll just make the new function a static, shall I?

Yes, it should be used by tcp connections from mingw hosts too.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]