This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RFC: Do not call write_pc for "signal SIGINT"

This FIXME has been there since the dawn of CVS.  Removing it causes
no testsuite regressions on x86_64-linux; I don't think it will on
other platforms either.

Any comments on this patch?  Otherwise I'll check it in after a little

This isn't the only place where Linux's internal errno codes can leak
back into user programs because of how we fiddle orig_eax.  I'll file
another bug report about that.

Daniel Jacobowitz

2008-08-28  Daniel Jacobowitz  <>

	PR gdb/2241
	* infcmd.c (signal_command): Do not specify a resume PC.

Index: infcmd.c
RCS file: /cvs/src/src/gdb/infcmd.c,v
retrieving revision 1.200
diff -u -p -r1.200 infcmd.c
--- infcmd.c	21 Aug 2008 20:13:08 -0000	1.200
+++ infcmd.c	28 Aug 2008 15:51:15 -0000
@@ -1123,11 +1123,7 @@ signal_command (char *signum_exp, int fr
   clear_proceed_status ();
-  /* "signal 0" should not get stuck if we are stopped at a breakpoint.
-     FIXME: Neither should "signal foo" but when I tried passing
-     (CORE_ADDR)-1 unconditionally I got a testsuite failure which I haven't
-     tried to track down yet.  */
-  proceed (oursig == TARGET_SIGNAL_0 ? (CORE_ADDR) -1 : stop_pc, oursig, 0);
+  proceed ((CORE_ADDR) -1, oursig, 0);
 /* Proceed until we reach a different source line with pc greater than

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]