This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] PPC: Skip call to __eabi in main()
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Jul 2008 01:44:27 -0300
- Subject: Re: [RFC] PPC: Skip call to __eabi in main()
- References: <20080721155343.404977d3@mesquite.lan>
On Mon, 2008-07-21 at 15:53 -0700, Kevin Buettner wrote:
> + if ((op & 0xfc000001) == 0x48000001)
> + {
> + CORE_ADDR displ = op & 0x03fffffc;
I think this would be more legible with #defines instead of these
hardcoded opcodes and bitmasks. Also, a comment above each #define
explaining what the value means, of course.
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center