This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: Hardware watchpoint register support for mips-linux.


On Mon, Apr 21, 2008 at 12:34:15PM -0700, David Daney wrote:
> Comments are welcome.

You've made most of my comments already.  My only addition is do not
use a new nm-linux.h at all.  Everything can be done from the
target_ops in mips-linux-nat.c now.

For infrun.c, can you just use resume instead of target_resume?

There's some GNU formatting issues but nothing huge.  Spaces,
newlines before function names in definitions.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]