Re: linux native async mode support

[Vladimir Prus <ghost at cs dot msu dot su>]

Nick Roberts wrote:

> #
> # Test asynchronous Machine Interface (MI) operations
> #
> 
> # This currently only works with native linux and the async remote protocol.
> if { !([isnative] && [istarget *-linux*]) \
> Â Â Â&& [board_info gdb_protocol] != "async" } then {
> Â return
> }
> 
> # The plan is for async mode to become the default but toggle for now.
> set saved_gdbflags $GDBFLAGS
> set GDBFLAGS "-ex \"maint set linux-async on\""
> 
> load_lib mi-support.exp
> 
> gdb_exit
> if [mi_gdb_start] {
> Â Â continue
> }
> 
> set testfile "basics"
> set srcfile ${testfile}.c
> set binfile ${objdir}/${subdir}/${testfile}
> if Â{ [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug
additional_flags=-DFAKEARGV}] != "" } {
> Â Â Âuntested mi-async.exp
> Â Â Âreturn -1
> }
> 
> mi_delete_breakpoints
> mi_gdb_reinitialize_dir $srcdir/$subdir
> mi_gdb_load ${binfile}
> 
> # mi_gdb_test cannot be used for asynchronous commands because there are
> # two prompts involved and this can lead to a race condition.
> 
> proc linux_async_tests {} {
> Â Â global mi_gdb_prompt
> Â Â global hex
> 
>   set line_main_head   [gdb_get_line_number "main ("]
>   set line_main_body   [expr $line_main_head + 2]
>   set line_main_next   [expr $line_main_head + 3]
> 
> Â Â send_gdb "start\n"
> Â Â gdb_expect {
> ÂÂÂÂÂÂÂÂ-re ".*\\^running\r\n\\^done\r\n$mi_gdb_prompt" {

I don't think this is right. MI is (supposed to be) extensible. In particular, new async
notification may be added. The above will break if any notification will be emitted
between ^running and ^done and the prompt.

> ÂÂÂÂÂÂÂÂ Â Âgdb_expect {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ-re "\\*stopped,thread-id=\"0\",frame=\{addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\".*basics.c\",line=\"$line_main_body\"\}\r\n$mi_gdb_prompt$"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ{ 
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âpass "Asynchronous response after start command"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ-re ".*$mi_gdb_prompt$" {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âfail "Asynchronous response after start command (2)"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂtimeoutÂ{
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âfail "Asynchronous response after start command (timeout 2)"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂ Â Â}
> ÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂ-re ".*$mi_gdb_prompt$" {
> ÂÂÂÂÂÂÂÂ Â Âfail "Asynchronous response after start command (1)"
> ÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂtimeout {fail "Asynchronous response after start command (timeout 1)"}
> Â Â }
> 
> Â Â send_gdb "next\n"
> Â Â gdb_expect {
> ÂÂÂÂÂÂÂÂ-re "\\^running\r\n\\^done\r\n$mi_gdb_prompt" {
> ÂÂÂÂÂÂÂÂ Â Âgdb_expect {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ-re "\\*stopped,reason=\"end-stepping-range\",thread-id=\"0\",frame=\{addr=\"$hex\",func=\"main\",args=\\\[\\\],file=\".*basics.c\",line=\"$line_main_next\"\}\r\n$mi_gdb_prompt$"
{
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âpass "Asynchronous response after next command"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ-re ".*$mi_gdb_prompt$" {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âfail "Asynchronous response after next command (2)"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂtimeout {
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ Â Âfail "Asynchronous response after next command (timeout 2)"
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ}
> ÂÂÂÂÂÂÂÂ Â Â}
> ÂÂÂÂÂÂÂÂ}

It appears there's a lot of duplicated logic above. Can we please have factor it out into a helper
function? This is not for the sake of abstract clarify -- I've already spend hours updating the
current MI testsuite for non-stop mode.

- Volodya