Re: [RFA] compilation error in remote.c on sparc-solaris

[Michael Snyder <msnyder at specifix dot com>]

On Fri, 2008-03-07 at 10:27 -0800, Joel Brobecker wrote:
> Hello,
> 
> I get the following warning when compiling remote.c on a sparc-solaris
> machine:
> 
>     remote.c: In function 'extended_remote_attach_1':
>     remote.c:2859: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'pid_t'
> 
> I think the problem is that, on sparc-solaris, type pid_t is defined
> as a "long", whereas on other machines I've built GDB on, it's an int.
> 
> Variable pid is defined as follow:
> 
>   pid_t pid;
> 
> I think it's good enough to change its type to "int". I've never seen
> a PID that's larger than 7 digits, so an int should always be big enough.
> In any case, that's what the pid_t structure uses for the pid.

Why not just cast it?


> 
> 2008-03-07  Joel Brobecker  <brobecker@adacore.com>
> 
>         * remote.c (extended_remote_attach_1): Make local variable pid an int
>         instead of a pid_t.
> 
> Tested on sparc-solaris by rebuilding remote.o (I tried with both
> a 32bit compiler and a 64bit compiler).
> 
> OK to apply?
> 
> Thanks,