Re: [RFA] Don't reset watchpoint block on solib load.

[Daniel Jacobowitz <dan at codesourcery dot com>]

On Wed, Jan 23, 2008 at 12:57:27PM +0300, Vladimir Prus wrote:
> So, I guess the solutions are either:
> 
> 1. Omit the move of condition parsing from this patch, or
> 2. Keep condition parsing in this patch, and then commit
> the use-multiple-locations-for-watchpoint patch which will
> immediately make condition only reparsed when breakpoint_re_set_one
> is called.
> 
> Given that use-multiple-locations-for-watchpoint patch is
> approved except for the bit that makes reparsing of condition
> optional, it seems that (2) is less work.

All this sounds fine to me.  I'm OK with this patch, which I believe
is the one here:
  http://sourceware.org/ml/gdb-patches/2007-11/msg00522.html

> For convenience, I attach the current version of 
> use-multiple-locations-for-watchpoint patch. The difference
> to the previous revision is as follows:
> 
> 
> @@ -966,7 +966,7 @@ update_watchpoint (struct breakpoint *b, int reparse)
>             value_free (v);
>         }
> 
> -      if (b->cond_string != NULL)
> +      if (reparse && b->cond_string != NULL)
>         {
>           char *s = b->cond_string;
>           if (b->loc->cond)
> 
> 
> Dan, is the patch still OK to commit?

Yes, it is.

-- 
Daniel Jacobowitz
CodeSourcery