This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BUG] BINOP_DIV and ptyp command


> I may be missing something, but it seems like special casing
> EVAL_AVOID_SIDE_EFFECTS for DIV/MOD/REM is no longer useful here

I don't think this is right. EVAL_AVOID_SIDE_EFFECTS is used when
computing the actual value is not needed. For instance, when you do
"ptype", the expression is evaluated in that mode.  So when you do
"ptype 3 div 2", we don't do the division, we just know that we're only
interested in the type of result.  So the expression evaluator will
return a struct value of the correct type but with a bogus contents,
instead of doing the division, only to discard the result down the road.

So the code you suggested we remove is useful.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]