This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve printf DFP support


On Tue, Jan 08, 2008 at 01:19:06PM -0200, Thiago Jung Bauermann wrote:
> param_ptr should be a const gdb_byte *, and the cast here should be
> removed. In addition, I believe the use of value_offset here is wrong.
> Other uses of value_offset are to obtain a memory address in the
> inferior address space, not in GDB's. Also, I think that value_contents
> should be used intead of value_contents_all so that the value's
> embedded_offset can be taken into account.

I believe that you are correct.  The value handling is another area of
GDB that could do with some cleaning up; I am not convinced the
multiple offsets dance is necessary...

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]