This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: GDB/libiberty support for IBM long double
- From: Daniel Jacobowitz <drow at false dot org>
- To: Luis Machado <luisgpm at linux dot vnet dot ibm dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, gdb-patches at sourceware dot org
- Date: Wed, 2 Jan 2008 11:55:19 -0500
- Subject: Re: GDB/libiberty support for IBM long double
- References: <200711090107.lA917ZGs027733@d12av02.megacenter.de.ibm.com> <Pine.LNX.4.64.0711130038330.29493@digraph.polyomino.org.uk> <1198783208.7822.51.camel@gargoyle> <jeprwrf6rp.fsf@sykes.suse.de> <1198852288.7822.56.camel@gargoyle> <20071230043845.GC24220@caradoc.them.org> <1199290287.13275.3.camel@gargoyle>
On Wed, Jan 02, 2008 at 02:11:27PM -0200, Luis Machado wrote:
> Hi,
>
> > I wonder if we really need to use floatformat_to_double instead of
> > floatformat_to_doublest for the split_half cases. It seems like that
> > relies unnecessarily on the host double format. Do things work better
> > if you use floatformat_to_doublest and DOUBLEST variables, instead
> > of floatformat_to_double (likewise floatformat_from_doublest)?
>
> The attached patch replaces the use of floatformat_to_double with
> floatformat_to_doublest, fixing the problem.
>
> There are other uses of floatformat_to_double in the function, by i'm
> not sure if we should just replace every call of that function with the
> "doublest" version (likewise with the floatformat_from_double ->
> floatformat_from_doublest replacement).
There is one other call, for NaN and infinity. That one should be
left alone, since we don't duplicate the necessary bits and the
precision is irrelevant.
However, could you test also replacing the two floatformat_from_double
calls in convert_doublest_to_floatformat?
--
Daniel Jacobowitz
CodeSourcery