This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] language.h minor cleanup
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: brobecker at adacore dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 17 Dec 2007 11:40:00 +0100 (CET)
- Subject: Re: [commit] language.h minor cleanup
- References: <20071217070301.GE32623@adacore.com>
> Date: Mon, 17 Dec 2007 11:03:01 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello,
>
> This is something I noticed while working on the "struct parse_context"
> task: There was one commented-out enum declaration that I decommented,
As far as I know the comment:
> -/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */
is right, so you shouldn't have comitted this :(. Perhaps it is now a
GCC extension to allow these, but as far as I remember older versions
of GCC didn't accept this.
In that pas we simply moved these enums to defs.h, which should always
be included before any other headers.
Mark