This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Debugging a Vlc dll with GDB.


On Fri, Dec 07, 2007 at 01:57:05AM +0000, Pedro Alves wrote:
> Humm, I found it useful, as in "ok, the breakpoint I set in a
> function that will only trigger after I do this, that, and that,
> is correctly set".  Now, I have to interrupt the inferior and
> do an info breakpoints to see if it got in.  If the breakpoint
> is in a plugin that gets loaded in reaction to some event, its
> even worse, as I'll have to poll...

Maybe there should be a single message when any number of pending
breakpoints are resolved?  Anyway, one issue at a time.

> >>  	  if (pending_break_support == AUTO_BOOLEAN_AUTO && -	      !nquery ("Make 
> >> breakpoint pending on future shared library load? "))
> >> +	      !nquery (_("\
> >> +Make breakpoint pending on future symbol file addition? ")))
> > Accurate, but I don't like it much... sounds awkward.
> > For the rest, I don't really like the churn on messages; would it work
> > to just push the error down below *not_found_ptr = 1, and make it a
> > NOT_FOUND_ERROR?
> 
> Yes it works, but do we want both the current error message,
> and NOT_FOUND_ERROR message that's already there, but not
> triggered currently, which is the message one usually sees?
> I guess you mean something like the attached?

No, I agree that looks silly.  I meant:

> -  if (!have_full_symbols () &&
> -      !have_partial_symbols () && !have_minimal_symbols ())
> -    error (_("No symbol table is loaded.  Use the \"file\" command."));
> -
>    if (not_found_ptr)
>      *not_found_ptr = 1;
> +  if (!have_full_symbols () &&
> +      !have_partial_symbols () && !have_minimal_symbols ())
> +    throw_error (NOT_FOUND_ERROR,
> +		   _("No symbol table is loaded.  Use the \"file\" command."));
>    throw_error (NOT_FOUND_ERROR, _("Function \"%s\" not defined."), copy);

That'll produce:

No symbol table is loaded.  Use the "file" command.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (main) pending.

Of course that still looks wrong.  It's not a shared library load that
we're waiting for.

Anyone else have concrete suggestions for these messages?

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]