This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 2] gdb/win32-nat.c: do not call CloseHandle on process and thread handles
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Pierre Muller <muller at ics dot u-strasbg dot fr>
- Date: Sun, 2 Dec 2007 00:46:06 -0500
- Subject: Re: [RFA 2] gdb/win32-nat.c: do not call CloseHandle on process and thread handles
- References: <002801c82d06$21bdf510$6539df30$@u-strasbg.fr> <4053daab0711220456q46cca9b4m3714c35bcc805518@mail.gmail.com> <002c01c82d0f$8c789050$a569b0f0$@u-strasbg.fr> <4053daab0711220637h2bc01450ra45a19f4013fd44d@mail.gmail.com> <20071123011754.GB31180@ednor.casa.cgf.cx> <006201c82dec$de431850$9ac948f0$@u-strasbg.fr> <20071124054405.GB4214@ednor.casa.cgf.cx> <000101c8300d$c1c85960$45590c20$@u-strasbg.fr>
On Mon, Nov 26, 2007 at 10:21:42AM +0100, Pierre Muller wrote:
>2007-11-26 Pierre Muller <muller@ics.u-strasbg.fr>
>
> *win32-nat.c (open_process_used): New static variable.
> (win32_init_thread_list): Remove call to CloseHandle for thread.
> (win32_delete_thread): Ditto.
> (fake_create_process): Set open_process_used if OpenProcess call
> is successful.
> (get_win32_debug_event): Do not close process handle.
> (do_initial_win32_stuff): Set open_process_used to zero.
> (win32_mourn_inferior): Call CloseHandle for current_process_handle
> if open_process_used is set.
> (win32_kill_inferior): Do not close process and main_thread handles.
Approved and applied.
Sorry for the delay. My cygwin build script for gdb is showing its age
and need some kicking with steel-toed shoes.
cgf