This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc] Add gdbarch to *_reg_to_regnum


Markus Deuling wrote:

> this patch adds gdbarch as parameter to the reg_to_regnum routines in
> gdbarch.c and the various tdep-files and its callers. 

This part seems fine to me, but would you please separate it out?

> This patch also consists of a mechanical change as preparation to get rid
> of current_gdbarch. In routines with a lot of current_gdbarchs it introduces
> a new variable "struct gdbarch *gdbarch = current_gdbarch" and replaces
> all the current_gdbarch's. In later patches gdbarch will be set properly
> (for example via objfile, macro replacement, ... ).

I'm not sure this is really helpful; I'd prefer if those were properly
replaced as you go forward -- as I think we'll have to think about some
of those a bit more.

One example: all the _fundamental_type changes are really obsolete, as
I'm about to commit a patch that removes fundamental types completely:
http://sourceware.org/ml/gdb-patches/2007-11/msg00085.html

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]