This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [rfc] [09/09] Get rid of current_gdbarch (gdbarch parameter to legacy_virtual_frame_pointer)
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: deuling at de dot ibm dot com (Markus Deuling)
- Cc: gdb-patches at sourceware dot org (GDB Patches)
- Date: Mon, 5 Nov 2007 17:08:36 +0100 (CET)
- Subject: Re: [rfc] [09/09] Get rid of current_gdbarch (gdbarch parameter to legacy_virtual_frame_pointer)
Markus Deuling wrote:
> this patchs adds gdbarch parameter to legacy_virtual_frame_pointer and updates its
> sole implementation in arch-utils.
Huh? There are three further instances of gdbarch_virtual_frame_pointer
(in m32c-tdep.c, mips-tdep.c, spu-tdep.c). The patch as-is would break
those platforms ...
I guess if those are fixed it would be OK to convert the function for now;
however, in the long run, the virtual_frame_pointer function needs to be
eliminated -- the tracepoint framework should really be getting this data
from the debug information.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com